controlbox2 / siren-of-shame

Automatically exported from code.google.com/p/siren-of-shame
0 stars 0 forks source link

TFS; Disabled project collections break TFS integration #29

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Disable a project collection in TFS
2. Connect to TFS using siren of shame

What is the expected output? What do you see instead?
System connects and lists project collections and projects. An exception is 
thrown indicating the disabled project collection is inaccesible.

What version of the product are you using? On what operating system?
1.6.0, Windows XP

If appropriate please provide a stack trace (see
http://sirenofshame.blogspot.com/2012/01/how-to-report-errors.html)

Please provide any additional information below.

Original issue reported on code.google.com by mur...@xsware.com on 15 Jul 2012 at 9:06

GoogleCodeExporter commented 9 years ago
murray: Is there a stack trace available?  Not strictly necessary to reproduce, 
but would help greatly.  Thanks, Lee.

Original comment by lpric...@gmail.com on 15 Jul 2012 at 9:09

GoogleCodeExporter commented 9 years ago
Sorry, I don't seem to be able to access your blog posting from work. The logs 
aren't available (view logs is disabled). I've attached a screenshot.

Following the pattern already employed in the code this snippet fixes it:

Update TfsServices.Configuration.MyTfsProjectCollection constructor. Add an 
additional exception handler.

            catch (TeamFoundationServiceUnavailableException ex)
            {
                _log.Debug("Service not available " + teamProjectCollectionNode, ex);
                CurrentUserHasAccess = false;
            }

Original comment by mur...@xsware.com on 15 Jul 2012 at 9:46

Attachments:

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 07d8e5f36ed4.

Original comment by lpric...@gmail.com on 28 Jul 2012 at 2:10

GoogleCodeExporter commented 9 years ago
Sorry for the delay.  I'll push this out in 1.6.3 today or tomorrow.  Your 
hunch about the code to fix was spot on BTW, thanks for the that.

Original comment by lpric...@gmail.com on 28 Jul 2012 at 2:13