search

controlbox2 / siren-of-shame

Automatically exported from code.google.com/p/siren-of-shame
0 stars 0 forks source link

TFS Workspaces with a cloaked directory no longer work #9

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.   Create a Workspace with a directory cloaked

What is the expected output? What do you see instead?
Expect CI screen to refresh, instead get a Null Pointer exception when trying 
to GetLatestChangeset

What version of the product are you using? On what operating system?
v1.3 against TFS 2010 server.

See attached diff for a fix for this issue.

Original issue reported on code.google.com by jsam...@gmail.com on 19 Jan 2012 at 3:04

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by jsam...@gmail.com on 19 Jan 2012 at 3:05

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by jsam...@gmail.com on 19 Jan 2012 at 3:07

Attachments:

GoogleCodeExporter commented 9 years ago 
Awesome, thank you so much for the diff!!  We'll get that in ASAP.

Original comment by lpric...@gmail.com on 19 Jan 2012 at 2:42

GoogleCodeExporter commented 9 years ago 
If the latest patch from Issue 7 is applied, this one is not needed (as it 
looks at the build's source version rather than hunting around for the latest 
changeset in the mapped folders)

Original comment by benpmor...@gmail.com on 24 Jan 2012 at 2:11

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision dc806c2ece86.

Original comment by lpric...@gmail.com on 27 Jan 2012 at 12:43

GoogleCodeExporter commented 9 years ago 
Agreed, benpmorgan's diff from Issue 7 should indeed fix this problem, however 
I took jsamuel's diff for now because as I noted in Issue 7 that diff wasn't 
working for gated check-ins.  If we can get that working I'll delete 
MyTfsBuildDefinition.GetLatestChangeset() entirely.

Original comment by lpric...@gmail.com on 27 Jan 2012 at 12:48