Docker images are built without version details

controlplaneio / kubesec

Security risk analysis for Kubernetes resources

https://kubesec.io

Apache License 2.0

1.21k stars 101 forks source link

Docker images are built without version details #121

Open 06kellyjac opened 3 years ago

06kellyjac commented 3 years ago

$ docker run --rm -i docker.io/kubesec/kubesec:v2 version
version unknown
git commit unknown
build date unknown

06kellyjac commented 2 years ago

Im going to fix this as part of #250

JOSHUAJEBARAJ commented 2 years ago

I think both of are different issue because the go-releaser only changes the binary version that is present in the release page It won't change the binary present inside the container here

06kellyjac commented 2 years ago

Yes I'm aware but I'm updating the version command so I'm fixing both separate issues at the same time.

The version will now list the version, full commit, source date epoch in RFC 3339 format, and unix epoch format

I'll either try plug those details into the docker build action or utilize goreleaser within the container builds

marcio-pessoa commented 2 years ago

This issue is still happening:

$ docker run --rm kubesec/kubesec version
Unable to find image 'kubesec/kubesec:latest' locally
latest: Pulling from kubesec/kubesec
a0d0a0d46f8b: Pull complete 
225a6626967c: Pull complete 
50cb987b6fe2: Pull complete 
404740fbf2d0: Pull complete 
66230eef9706: Pull complete 
7cd616b8ef56: Pull complete 
Digest: sha256:1085be3c2494be9d8dc4884e7ceaf7a79fca650f02d1e36d6b1ac317e0495cb3
Status: Downloaded newer image for kubesec/kubesec:latest
version unknown
git commit unknown
build date unknown

MarioUhrik commented 1 year ago

Hi @06kellyjac, if you're interested, I can try to open a PR where I fix this issue by:

supplying git tag/commit/date information from GitHub Actions into the Docker Build GHA, e.g. like this
editing the Dockerfiles so the env variables from the previous step are passed into ldflags argument of go build, e.g. like this (Dockerfile in the question)
as a bonus, fix the harmless path typo at https://github.com/controlplaneio/kubesec/blob/master/Dockerfile.scratch#L13

06kellyjac commented 1 year ago

Thanks for the offer but there are a couple other tweaks I want to make to the Dockerfiles so ill do that in 1 pr

Nice catch on that typo