search

controlplaneio / kubesec

Security risk analysis for Kubernetes resources
https://kubesec.io
Apache License 2.0
1.22k stars 103 forks source link

Test GHA #554

Closed spiarh closed 10 months ago

06kellyjac commented 10 months ago

Im not a fan of this. If this is for kubesec-webhook what was wrong with cloning the repo here, doing a build, and pushing, all in this repo?

mrcdb commented 10 months ago

Im not a fan of this. If this is for kubesec-webhook what was wrong with cloning the repo here, doing a build, and pushing, all in this repo?

I have a PR open for that in the kubesec-webhook repo: https://github.com/controlplaneio/kubesec-webhook/pull/33 . My only (minor) concern about managing webhook release from this repo is with the versioning of the container image. The way we are doing this for kubesec is by using the same version number as in the tag triggering the GHA, which would be obviously different for kubesec-webhook.

06kellyjac commented 10 months ago

It wasn't meant to be a permanent solution & could have had a hard coded commit/tag in yaml plus manual trigger