search

controlsfx / controlsfx

High quality UI controls to complement the core JavaFX distribution
https://controlsfx.org
BSD 3-Clause "New" or "Revised" License
1.53k stars 265 forks source link

Autocompletion method clash with javafx 21 due to changed event signature #1516

Closed Siedlerchr closed 8 months ago

Siedlerchr commented 9 months ago

I was trying out the latest EA of javafx 21 in our project and stumbled across this issue:

'addEventHandler(EventType<E>, EventHandler<E>)' in 'org.controlsfx.control.textfield.AutoCompletionBinding' clashes with 'addEventHandler(EventType<E>, EventHandler<? super E>)' in 'javafx.event.EventTarget'; both methods have same erasure, yet neither overrides the other

'removeEventHandler(EventType<E>, EventHandler<E>)' in 'org.controlsfx.control.textfield.AutoCompletionBinding' clashes with 'removeEventHandler(EventType<E>, EventHandler<? super E>)' in 'javafx.event.EventTarget'; both methods have same erasure, yet neither overrides the other
abhinayagarwal commented 9 months ago

Yes, we might not need these methods any longer.