Provide a public getter method for the Dialog used by a Wizard

controlsfx / controlsfx

High quality UI controls to complement the core JavaFX distribution

https://controlsfx.org

BSD 3-Clause "New" or "Revised" License

1.53k stars 265 forks source link

Provide a public getter method for the Dialog used by a Wizard #1542

Open ianrenton opened 4 months ago

ianrenton commented 4 months ago

I believe this provides the access necessary to resolve #756, #976, #999 and #1388.

I have chosen to make getDialog() public rather than alternative methods such as a setDialog() or making dialog itself protected as I believe this offers the simplest possible change to meet the needs of these issues (and my own).

I can't see any obvious disadvantage to making the Wizard dialog accessible in this way, but if there is some subtlety that I have missed, please let me know.

github-actions[bot] commented 4 months ago

Hi ianrenton,

Welcome to ControlsFX and thank you for taking time to contribute to this project.

We do not recognise you as a contributor. Can you please sign ControlsFX Individual Contributor Agreement: https://cla.controlsfx.org ?

Siedlerchr commented 3 months ago