search

controlsfx / controlsfx

High quality UI controls to complement the core JavaFX distribution
https://controlsfx.org
BSD 3-Clause "New" or "Revised" License
1.57k stars 269 forks source link

Non-blocking Wizard #623

Open JonathanGiles opened 10 years ago

JonathanGiles commented 10 years ago

Original report by Andreas Liebelt (Bitbucket: aliebelt, GitHub: aliebelt).

There are some use cases where the UI should be updated (in the background) even if a dialog is shown.

Currently there is only a blocking showAndWait() method in the Wizard.

I would propose to add a show() method to keep the UI rendered while using the Wizard. (there will be the need for a property where you can listen to for the result of the wizard)

JonathanGiles commented 10 years ago

Original comment by Andreas Liebelt (Bitbucket: aliebelt, GitHub: aliebelt).

I'm a little bit confused. The showAndWait method blocks and the Wizard is shown but the primary Stage is still updated in the background. I though blocking calls stops the rendering of the UI. Is there maybe something I have not understood regarding blocking method calls and UI refresh?

JonathanGiles commented 10 years ago

Original comment by Andreas Liebelt (Bitbucket: aliebelt, GitHub: aliebelt).

I meant non-blocking but wrote non-modal. Maybe I used to much modal windows which blocked the UI ;)

I will try to create a pull request.

JonathanGiles commented 10 years ago

Original comment by Jonathan Giles (Bitbucket: JonathanGiles, GitHub: JonathanGiles).

You're conflating modality and blocking, which are two separate concepts. It sounds to me like you want a non-blocking API, which is something we can do in a future release (the code is already there, just needs uncommenting for the most part). If you can, could you do a pull request to add this functionality?