search

controlshift / action-network-rest

Ruby client for interacting with the ActionNetwork REST API
MIT License
8 stars 4 forks source link

feat: Add ability to update a person #14

Closed dweebo closed 4 years ago

dweebo commented 4 years ago

First of all thanks for building this library!

I've been tasked with updating some of our activists records to set some custom fields based on BOE data and this library is going to make the task MUCH less tedious.

I needed a way to update a persons records so this PR adds that.

See updated examples in the README.

Thanks again!

dweebo commented 4 years ago

Thanks for this. Would prefer to keep the interface for create/update a hash and ID like the other similar methods in the gem for other resources. It's probably more likely that consuming code has those simpler data types than a struct like object that our GETs return.

If you make that tweak would be happy to merge and cut a new version of gem.

I was wondering about that, I did see that update pattern in a few other spots.

For my purposes I will need to first lookup a user by email using your existing code, so I do already have the person object but I see what you are saying.

I'll rework this PR

dweebo commented 4 years ago

Updated as requested to pass in hash and ID like other update methods. Let me know if you see anything else needed.