search

conventional-changelog-archived-repos / conventional-changelog-angular

deprecated, instead use https://github.com/conventional-changelog/conventional-changelog monorepo
81 stars 63 forks source link

Test Commit Type Else #5

Closed ghost closed 6 years ago

ghost commented 8 years ago

The long chain of commit type conditionals doesn't have a test for the else case where no type matches.

In my fork of conventional-changelog-angular I added gitDummyCommit(['what(ngOptions): unknown type', 'BREAKING CHANGE: The Change is huge.']); to the BREAKING CHANGE test case, along with expect(chunk).to.include('what'); as an assertion.

That resolve that missing test case.

stevemao commented 8 years ago

PR welcome :)

hutson commented 6 years ago

We're closing this issue out as this repository has been merged into our conventional-changelog mono-repository.

If you would like to see this change incorporated into conventional-changelog please consider re-opening the issue against the conventional-changelog mono-repository.