search

conventional-changelog-archived-repos / conventional-changelog-angular

deprecated, instead use https://github.com/conventional-changelog/conventional-changelog monorepo
81 stars 63 forks source link

fix(parserOpts.noteKeywords): make the breaking change regex stricter #9

Closed boschni closed 8 years ago

boschni commented 8 years ago

The parser currently parses any occurrence of the string "breaking change" as breaking change. This is not in compliance with the Angular commit specs as it should look for a line starting with "BREAKING CHANGE:". I ran into this issue when trying to commit a non-breaking feature with the words "breaking changes" in the commit message.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ef5b2a2b3080a52e5e1def36c13bfe6eb6831f91 on u-nikos:master into 354466bbf0abe0d6e26569a4f5879ee90f273da1 on stevemao:master.

stevemao commented 8 years ago

This should be done at https://github.com/stevemao/conventional-commits-parser, please open an issue there. Thanks :smile:

stevemao commented 8 years ago

The real question is how we should build noteKeywords api.

boschni commented 8 years ago

I'll open an issue there, but wouldn't the parserOpts.noteKeywords property in conventional-changelog-angular override the one in conventional-commits-parser?

Edit: And the conventional-commits-parser isn't really tied to angular right?

stevemao commented 8 years ago

well I agree any noteKeywords should be at the beginning of a sentence.

stevemao commented 8 years ago

@u-nikos I've created an issue there. https://github.com/conventional-changelog/conventional-commits-parser/issues/23