search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

fix(package): add version to package.json #1

Closed ds82 closed 8 years ago

ds82 commented 8 years ago

Without a version entry in package.json a npm install via git URL fails

npm i https://github.com/kentcdodds/validate-commit-msg.git
npm ERR! addLocal Could not install [...]
npm ERR! No version provided in package.json
codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #1 into master will not affect coverage as of a9d68f6

@@            master      #1   diff @@
======================================
  Files            1       1       
  Stmts           40      40       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             40      40       
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of a9d68f6

Powered by Codecov. Updated on successful CI builds.

noamokman commented 8 years ago

:+1:

ds82 commented 8 years ago

discussed that in https://github.com/semantic-release/semantic-release/issues/116 and modified my PR accordingly.

kentcdodds commented 8 years ago

I need to give you an apology. For some reason, I want watching this repository so I want getting notifications about issues and pull requests. I am so incredibly sorry. Please forgive me. I really feel awful. I hope my unresponsiveness doesn't hinder you contributing more in the future.

As for your specific pull request, I'll give it a closer look soon.

ds82 commented 8 years ago

Never mind, that happened to me once, too ;)