search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

fix(robustness): handle undefined message buffer, closes #9 #10

Closed bahmutov closed 8 years ago

bahmutov commented 8 years ago

should protect when called without an actual message

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #10 into master will not affect coverage as of 2f8e261

@@            master     #10   diff @@
======================================
  Files            1       1       
  Stmts           40      42     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             40      42     +2
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 2f8e261

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

I need to give you an apology. For some reason, I want watching this repository so I want getting notifications about issues and pull requests. I am so incredibly sorry. Please forgive me. I really feel awful. I hope my unresponsiveness doesn't hinder you contributing more in the future.

As for your specific pull request, I'll give it a closer look soon.

kentcdodds commented 8 years ago

Thanks!