conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

chore(travis): re-enabled auto-release #102

Closed nickbalestra closed 6 years ago

nickbalestra commented 6 years ago

This PR to re-enable semantic-release, as discussed on #94. Needed tokens are encrypted directly on the travis.yml

As the GH token is also required for semantic-release, and as I've not yet write access to this repo, I guess that auto-release could still potentially fail ..

codecov-io commented 6 years ago

Codecov Report

Merging #102 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #102   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         126    126           
=====================================
  Hits          126    126

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8486495...a31e630. Read the comment docs.

nickbalestra commented 6 years ago

@Garbee @kentcdodds - I've added the needed tokens directly on the travis.yml but I guess I need to have publish rights both on npm && on this repo on GH in order for auto-release to work ...?

If that's the case once i get both those rights, this PR should work

Garbee commented 6 years ago

Just invited you to get write access to the repo to make sure this has the best chance at working.

nickbalestra commented 6 years ago

Thanks @Garbee I've also updated the PR with the suggested indentation. Over to you for merging and 🤞

Garbee commented 6 years ago

LGTM. Let's merge and see.

stevemao commented 6 years ago

@nickbalestra I invited you to the org. welcome onboard :)

nickbalestra commented 6 years ago

Thank you @stevemao !!