conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

feat(autoFix): fix the commit message case instead of ignoring case #106

Closed cmalard closed 6 years ago

cmalard commented 6 years ago

First step to auto fix things :-)

validateMessage() is becoming monstruous... but if there is a big refacto to come, it may not be a good idea to split it in this PR. Tell me ;-)

Close #105

codecov-io commented 6 years ago

Codecov Report

Merging #106 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #106   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         126    134    +8     
=====================================
+ Hits          126    134    +8
Impacted Files Coverage Δ
lib/validateMessage.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 888617b...789436e. Read the comment docs.

Garbee commented 6 years ago

LGMT since the new parameter is guarded in triggering the functionality needed by it. Good catch seeing that on the first round. :wink:

I wouldn't worry about refactoring V1's code. It's already mostly understood (even for its flaws.) Any refactoring as well, I'd like us to use newer tech which would mean upgrading the node version requirement. V2 is going to depend on other packages to do the heavy lifting. So that alone will clean things up a lot. I do have an active folder working on some initial experimentation for that, but it comes in between other projects. :ocean: