conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

Validate all new commits on a branch #107

Closed cmalard closed 6 years ago

cmalard commented 6 years ago
$ validate-commit-msg --from=develop 

screen

Not sure if I should continue this, cf your big refacto @Garbee ?

Things to improve:

Fix #11

codecov-io commented 6 years ago

Codecov Report

Merging #107 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #107   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         134    134           
=====================================
  Hits          134    134

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e048fb...1cca184. Read the comment docs.

Garbee commented 6 years ago

Hmm. Let's discuss this on the main issue. I have a few concerns with introducing this internally. Commenting on that now...

Garbee commented 6 years ago

From the discussion in the issue this type of feature won't be included internally at this time. Details are in the issue for how this kind of thing could get included in core at a future point. For now though, developers need to provide a single commit at a time, however that is done. Which seems fair enough even if the processing code they need to maintain is slightly larger.

I don't see the value benefit in maintaining this within the scope of this project given the current lack of known external details that can have an affect on implementation needs.