Closed cmalard closed 6 years ago
Merging #107 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #107 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 134 134
=====================================
Hits 134 134
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2e048fb...1cca184. Read the comment docs.
Hmm. Let's discuss this on the main issue. I have a few concerns with introducing this internally. Commenting on that now...
From the discussion in the issue this type of feature won't be included internally at this time. Details are in the issue for how this kind of thing could get included in core at a future point. For now though, developers need to provide a single commit at a time, however that is done. Which seems fair enough even if the processing code they need to maintain is slightly larger.
I don't see the value benefit in maintaining this within the scope of this project given the current lack of known external details that can have an affect on implementation needs.
Not sure if I should continue this, cf your big refacto @Garbee ?
Things to improve:
helpMessage
many times (`Please fix and consider...), don't know how to address it for now. Best display should be to have it once, but it would requires many changes.Fix #11