search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

feat(validateMessage): display original message when it is not valid #12

Closed cmalard closed 8 years ago

cmalard commented 8 years ago

Really helpfull to not have to rewrite everything. It happened to me because I went over the 100 chars limit... :-)

It will change this output :

INVALID COMMIT MSG: is longer than 100 characters !

to :

INVALID COMMIT MSG: is longer than 100 characters !
feat(superCoolScopeDesignedToBeSpeciallyLong): talk about this super cool feature, but talking about it too much making it exceed the length limit
codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #12 into master will increase coverage by +3.64% as of 2e98fb8

@@            master     #12   diff @@
======================================
  Files            1       1       
  Stmts           55      53     -2
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             53      53       
  Partial          0       0       
+ Missed           2       0     -2

Review entire Coverage Diff as of 2e98fb8

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

I need to give you an apology. For some reason, I want watching this repository so I want getting notifications about issues and pull requests. I am so incredibly sorry. Please forgive me. I really feel awful. I hope my unresponsiveness doesn't hinder you contributing more in the future.

As for your specific pull request, I'll give it a closer look soon.

kentcdodds commented 8 years ago

If you could remove that function and see if we can keep the same coverage that'd be great. I think this looks awesome. Let me know when it's ready! Thanks!

kentcdodds commented 8 years ago

Unfortunately it looks like this is breaking some tests. Could you look at that please?

cmalard commented 8 years ago

:+1:

kentcdodds commented 8 years ago

Looks great. Thanks!

By the way, GitHub doesn't notify me when you update the PR. Glad I checked back! :D Thanks for the PR!