search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
557 stars 100 forks source link

feat(validateMessage): Allow semver commits #17

Closed jcollado closed 8 years ago

jcollado commented 8 years ago

In this PR the IGNORED regular expression is updated to skip commits that contain just a valid semver as the ones generated by npm version.

Closes #13

codecov-io commented 8 years ago

Current coverage is 96.36%

Merging #17 into master will increase coverage by +0.07% as of 5804653

@@            master     #17   diff @@
======================================
  Files            1       1       
  Stmts           54      55     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             52      53     +1
  Partial          0       0       
  Missed           2       2

Review entire Coverage Diff as of 5804653

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

I need to give you an apology. For some reason, I want watching this repository so I want getting notifications about issues and pull requests. I am so incredibly sorry. Please forgive me. I really feel awful. I hope my unresponsiveness doesn't hinder you contributing more in the future.

As for your specific pull request, I'll give it a closer look soon.

kentcdodds commented 8 years ago

This is great. Thanks for the work. Unfortunately it no longer merges cleanly (sorry about that!) If you could please rebase and update the PR to the current codebase, I'd really appreciate it. Thank you.

jcollado commented 8 years ago

@kentcdodds Rebased

kentcdodds commented 8 years ago

Excellent. Thanks!