search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

Support empty commits #24

Closed remy closed 8 years ago

remy commented 8 years ago

Empty commits should abort the commit, but the validation still fails:

screen shot 2016-03-06 at 08 27 21

This change strips comments from the commit before verification and then if the message is actually empty, it'll abort the commit (with the same default git message):

screen shot 2016-03-06 at 08 28 26
codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #24 into master will not affect coverage as of b3d7b76

@@            master     #24   diff @@
======================================
  Files            1       1       
  Stmts           62      67     +5
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             62      67     +5
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of b3d7b76

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

Awesome, thanks!