search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

fix(.git-location) : Handles case where .git is a file instead of dir… #28

Closed ryan-kimber closed 8 years ago

ryan-kimber commented 8 years ago

When using git submodules, the .git folder is actually a file containing a property that tells us where we should be looking for the files that are usually in the .git folder.

We can use the contents of that file to find where the COMMIT_EDITMSG is actually located.

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #28 into master will not affect coverage as of 804b71c

@@            master     #28   diff @@
======================================
  Files            1       1       
  Stmts           71      82    +11
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             71      82    +11
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 804b71c

Powered by Codecov. Updated on successful CI builds.

kentcdodds commented 8 years ago

I'll have to pull this down and test it out on a project. Hopefully will get it merged soon.

kentcdodds commented 8 years ago

Looks good to me! Thanks!

ryan-kimber commented 8 years ago

Thanks for getting it merged in! One less forked npm module to depend on!

On Sun, Mar 20, 2016 at 11:51 PM, Kent C. Dodds notifications@github.com wrote:

Merged #28 https://github.com/kentcdodds/validate-commit-msg/pull/28.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/kentcdodds/validate-commit-msg/pull/28#event-596621404

kentcdodds commented 8 years ago

Thanks for contributing :-)