search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
557 stars 100 forks source link

feat(subjectPattern): allow simple subject validation #30

Closed erquhart closed 8 years ago

erquhart commented 8 years ago

Provide the following config options to support simple subject validation:

subjectPattern: A regex to match the subject against. subjectPatternErrorMsg: A custom error message for subject pattern mismatches.

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #30 into master will not affect coverage as of 5468c0f

@@            master     #30   diff @@
======================================
  Files            1       1       
  Stmts           82      87     +5
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit             82      87     +5
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 5468c0f

Powered by Codecov. Updated on successful CI builds.

erquhart commented 8 years ago

For reference, my specific use case is a project where developers must include the Jira issue key at the beginning of the commit message subject (but after the type and scope). I'm certain there are plenty of valid use cases for this.

I've implemented my fork in one of our projects locally and it works well.

kentcdodds commented 8 years ago

LGTM :+1: