search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
557 stars 100 forks source link

fix(lib): make merge commit regex even less strict (fix #35) #36

Closed opatut closed 8 years ago

opatut commented 8 years ago

From the git source 1 we can see that the only part that git generates for sure in the merge commit message is the prefix Merge. This commit reduces the strictness of the merge detection to only that. While this might allow false postives, I consider these better than false negatives (where committing is disallowed and people have to use --no-verify).

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #36 into master will not affect coverage as of 4f075ad

@@            master     #36   diff @@
======================================
  Files            1       1       
  Stmts           88      88       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             88      88       
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 4f075ad

Powered by Codecov. Updated on successful CI builds.