conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

validate-commit-msg breaks on new version of validate-conventional-types #43

Closed hisabimbola closed 7 years ago

hisabimbola commented 7 years ago

validate-conventional-types just released a new version that includes additional commit types. This module is throwing errors when it's being used because it's not recognised. validate-conventional-types is being used in commitzen-cli.

The fix will be to fetch all commit types from validate-conventional-types module and not hard-code it as seen here

I will try to submit a PR for this

hisabimbola commented 7 years ago

I just looked through the code and I saw that there is a feature to add load external module or dependency, I think that fixes this issue but since commitzen uses the module to load commit types, shouldn't this module do likewise, and make it the standard.

kentcdodds commented 7 years ago

Sounds good. PRs welcome