conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

fix: use default commit types #46

Closed mattlewis92 closed 7 years ago

mattlewis92 commented 7 years ago

I'm currently getting this thrown when I try and commit anything to my modules:

/Users/mattlewis/Code/open-source/angular2-calendar/node_modules/validate-commit-msg/index.js:87
    if (types !== '*' && types.indexOf(type) === -1) {
                               ^

TypeError: types.indexOf is not a function
    at validateMessage (/Users/mattlewis/Code/open-source/angular2-calendar/node_modules/validate-commit-msg/index.js:87:32)
    at /Users/mattlewis/Code/open-source/angular2-calendar/node_modules/validate-commit-msg/index.js:149:10

This should do the trick, happy to follow up with a test, just wanted to get something out the door as I'm currently unable to commit to any of my modules 😄

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #46 into master will not change coverage

@@           master   #46   diff @@
===================================
  Files           1     1          
  Lines          91    90     -1   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
- Hits           91    90     -1   
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 8e0d4eb...d2048ec

kentcdodds commented 7 years ago

Ah, this makes sense. Thanks!