search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

docs(README): Clarify usage with husky #49

Closed markdalgleish closed 7 years ago

markdalgleish commented 7 years ago

As someone who wasn't familiar with how husky worked, I had to dig through the docs a little bit to figure out that "commit-msg" wasn't a valid script. I figured it would be much better to be completely explicit about how to set it up, so people can just copy-and-paste for the recommended setup.

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #49 into master will not change coverage

@@           master   #49   diff @@
===================================
  Files           1     1          
  Lines          90    90          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits           90    90          
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update eb4962f...213721a

kentcdodds commented 7 years ago

Awesome. Thank you so much for this!

kentcdodds commented 7 years ago

Also, sorry you lost some time getting this working!

markdalgleish commented 7 years ago

No worries at all, don't sweat it. Thanks for your awesome work on this.