Closed oneezy closed 7 years ago
Cool, thanks for finding that. Could you makeapullrequest.com?
Hey Kent, I'm having weird difficulty in making this commit.
First I tried to do it with semantic-release
and commitizen
and it seems like it almost worked,
? Select the type of change that you're committing: docs: Docu
? Denote the scope of this change ($location, $browser, $compile, etc.):
README
? Write a short, imperative tense description of the change:
Fixed typo
? Provide a longer description of the change:
? List any breaking changes or issues closed by this change:
closes (#53)
'.' is not recognized as an internal or external command,
operable program or batch file.
{ Error: Command failed: git commit -m "docs(README): Fixed typo" -m "" -m "" -m "" -m "closes (#53)"
'.' is not recognized as an internal or external command,
operable program or batch file.
at ChildProcess.exithandler (child_process.js:211:12)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)
at maybeClose (internal/child_process.js:885:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
killed: false,
code: 1,
signal: null,
cmd: 'git commit -m "docs(README): Fixed typo" -m "" -m "" -m "" -m "closes (#53)" ' }
Then I tried to just do a regular git commit
and I receive this error:
$ git commit -m "Fix typo (#53)"
'.' is not recognized as an internal or external command,
operable program or batch file.
This only happens w/ your repo.. I'm not sure what the issue is.
On another note, trying Attempt 1 raises a few questions,
By default semantic-release
will push everything up to NPM, but since this is a Forked repo, that step isn't really necessary. Is semantic release smart enough to know the difference or is this something that the developer needs to be aware of?
I'm pretty fresh w/ semantic-release so I'm not sure about these small intricacies.
Hey @oneezy, I apologize that you had these difficulties! I've just worked on things to make them a little more straightforward and hopefully improve your contributing experience!
Could you follow the new Contributing guidelines and let me know whether that works better for you.
As with semantic-release
, you should probably not be doing anything with that directly. Commitizen however should definitely work. Give it another shot and let me know if you have any additional trouble. Thanks!
I hope it's ok I went through and fix that @oneezy!
Just going through I noticed that your license badge link is going to a 404. https://github.com/kentcdodds/validate-commit-msg/blob/master/other/LICENSE
The culprit being:
https://github.com/kentcdodds/validate-commit-msg/blob/master/
OTHER
/LICENSE