Closed haltcase closed 7 years ago
@@ master #55 diff @@
===================================
Files 1 1
Lines 90 90
Methods 0 0
Messages 0 0
Branches 0 0
===================================
Hits 90 90
Misses 0 0
Partials 0 0
Powered by Codecov. Last update 3386784...28dbf2d
Would you like to add yourself to the contributors table? See the contributing guidelines for how.
@kentcdodds I ran into a few issues along the way.
1) stringstream
was not installed by yarn
This threw `Error: Cannot find module 'stringstream'` when trying `yarn run add-contributor`.
+-- all-contributors-cli@3.0.7
| `-- request@2.79.0
| `-- UNMET DEPENDENCY stringstream@~0.0.4
`-- codecov.io@0.1.6
`-- request@2.42.0
`-- UNMET OPTIONAL DEPENDENCY stringstream@~0.0.4
I had to manually install stringstream
.
2) istanbul (?) error on yarn run validate
I haven't used istanbul so I don't know for sure, maybe it's a Windows issue. I'm on Windows as evidenced by the empty line thing apparently.
(function (exports, require, module, __filename, __dirname) { @IF EXIST "%~dp0\node.exe" (
^
SyntaxError: Invalid or unexpected token
3) No emoji even though I selected Documentation
. From what I understand it should have received :book:
I'll fix up what you've commented on.
huh, that's weird. If you have any more trouble, don't worry about it and I'll merge it as-is. Thanks!
Thanks!
No bigs, thanks man. All that for a couple double quotes :stuck_out_tongue_closed_eyes:
Yeah, sorry about that. It's worth it to me to recognize those who help with the project! Thanks!
Yep I didn't mean anything by that - it's cool that you have that recognition front and center, I appreciate that.
It's cool that you contributed to the project. I appreciate that.
😀 ❤️
Change single quotes to double quotes in the example for
config.subjectPatternErrorMsg
.