conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard

http://conventionalcommits.org/

MIT License

557 stars 100 forks source link

test: add test for optional scope #66

Closed AndersDJohnson closed 7 years ago

AndersDJohnson commented 7 years ago

Adds a test to prove optional scope is supported. Probably this should be added in documentation as well.

codecov-io commented 7 years ago

Codecov Report

Merging #66 into master will not impact coverage.

@@          Coverage Diff          @@
##           master    #66   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         121    121           
=====================================
  Hits          121    121

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5769f1...d3e81f2. Read the comment docs.

kentcdodds commented 7 years ago

Cool! Could you add the docs too?

Garbee commented 7 years ago

This is essentially duplicating should allow empty scope. Perhaps if this is added to the top then the allowing empty should be removed since it is the same test coverage?

AndersDJohnson commented 7 years ago

@Garbee Ah I didn't notice that existing test. We could close the PR if you wish.

kentcdodds commented 7 years ago

Thanks. Yeah, we'll go ahead and close this one. Thanks!

AndersDJohnson commented 7 years ago

For docs, see #67.