conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard

http://conventionalcommits.org/

MIT License

556 stars 101 forks source link

fix(inputMsg): input can be also a commit message #87

Closed stevemao closed 7 years ago

stevemao commented 7 years ago

Fix regression from https://github.com/kentcdodds/validate-commit-msg/commit/d850cf47265d5ff18e86a3a743678ecfc7d66c03

stevemao commented 7 years ago

CC @krishna63

codecov-io commented 7 years ago

Codecov Report

Merging #87 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #87   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         126    126           
=====================================
  Hits          126    126

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd32032...7c20bdd. Read the comment docs.

krishna63 commented 7 years ago

@stevemao : May i know the reason behind this PR , PLS

stevemao commented 7 years ago

Specifying commit message as input doesn't work any more

On 13 Jun. 2017 10:47 pm, "krishna63" notifications@github.com wrote:

@stevemao https://github.com/stevemao : May i know the reason behind this PR , PLS

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kentcdodds/validate-commit-msg/pull/87#issuecomment-308104370, or mute the thread https://github.com/notifications/unsubscribe-auth/AGBiLvytBeS5S4BpYxfhxPlEECEQqJZXks5sDoTCgaJpZM4N3-s_ .

stevemao commented 7 years ago

I'm closing this since https://github.com/conventional-changelog/validate-commit-msg/pull/92#issuecomment-313691307 is merged. Please comment if I'm wrong @maxcnunes @Garbee Thanks.