search

conventional-changelog-archived-repos / validate-commit-msg

DEPRECATED. Use https://github.com/marionebl/commitlint instead. githook to validate commit messages are up to standard
http://conventionalcommits.org/
MIT License
556 stars 101 forks source link

[cli] input is ignored, output is misleading #96

Closed jklmli closed 7 years ago

jklmli commented 7 years ago

The CI docs mention passing in the commit message.

After trying to set this up in CircleCI, I realized that the CLI completely ignores the input arguments. It actually reads from the .git/COMMIT_EDITMSG file, which is the last edited commit message for that git client. In a CI environment, this'll be empty because the VM didn't commit anything.

stevemao commented 7 years ago

see https://github.com/conventional-changelog/validate-commit-msg/pull/87

jklmli commented 7 years ago

From the releases page, it looks like my best bet is rolling back to 2.12.1 in the meantime?

stevemao commented 7 years ago

I believe https://github.com/conventional-changelog/validate-commit-msg/pull/92 should solve the problem. Feel free to give it a shot :)

jklmli commented 7 years ago

Cool, I haven't tried it out yet but I've verified 2.12.1 does work.

stevemao commented 7 years ago

I'm closing this since https://github.com/conventional-changelog/validate-commit-msg/pull/92#issuecomment-313691307 is merged. Please comment if I'm wrong @maxcnunes @Garbee Thanks.