search

conventional-changelog / commitlint

📓 Lint commit messages
https://commitlint.js.org
MIT License
16.71k stars 899 forks source link

allow to require signed commits #321

Open KnisterPeter opened 6 years ago

KnisterPeter commented 6 years ago

Expected Behavior

A commit should be rejected if commitlint is configured for requiring a signed commit.

Current Behavior

There is no option to require signed commits.

Affected packages

Context

I would like to have me and my contributors to require sign git commits. There is support for this in github. And in the github project settings one could configure that signed commits are required on PRs, but if just refuses to merge a PR instead of refuse to accept a commit.
Failing more early would simplify the process.

marionebl commented 6 years ago

Good idea, want to help out with this? I think a signature-empty rule should do the trick.

We might have to extend conventional-commits-parser to include a signature field for this to work.

Want to lend a hand?

KnisterPeter commented 6 years ago

Sure, I'll give it a shot

tomraithel commented 5 years ago

@KnisterPeter @marionebl Is this feature request still open? I could take a look into that if you don´t mind.

KnisterPeter commented 5 years ago

@tomraithel This is still open and would be great. I had no time until now so: yes give it a shot :smiley:

tomraithel commented 5 years ago

Hmm, after taking some time to investigate, I came to the conclusion that it´s currently not possible to add that feature.

Reason is, that the conventional-commits-parser currently is only able to process commit messages whereas the signature information is not part of the commit message.

From my point of view there is unfortunately nothing we can do here.