search

conventional-changelog / commitlint

📓 Lint commit messages
https://commitlint.js.org
MIT License
16.83k stars 905 forks source link

refactor: switch from chalk to styleText (node:util) #4008

Open escapedcat opened 6 months ago

escapedcat commented 6 months ago

Expected Behavior

Colors should work like before in the terminal but without an extra dependency

Packages using this dep:

Current Behavior

https://github.com/chalk/chalk is being used

Affected packages

Possible Solution

No response

Context

https://twitter.com/sitnikcode/status/1776162867907015023

letsaguiar commented 6 months ago

Since styleText is a feature added in node version 21.7.0 this introduces a breaking change, right?

escapedcat commented 6 months ago

@letsaguiar ah thanks! I just saw the tweet but didn't check which version is needed. In this case this issue should wait till

  1. Version 22 is out
  2. We have a better reason for a breaking change
knocte commented 6 months ago

Version 22 is out

If you raise the node version requirement to 22, then you break compatibility with Ubuntu LTS.

escapedcat commented 6 months ago

Yeah, this is something for the future. Wouldn't want to break anything because of this.