Open wlc015f opened 2 months ago
Which version did you use before? Can you show some terminal output to make your issue more understandable. And update the title to describe your issue better. Thanks!
Thanks for clarifying your issue!
The update from 8.3.5 to 19.2.1 has several breaking issues.
Looking at it now it would have been good to add a flag to enable/disable on multiple scopes. Might have even been a breaking change I guess but we didn't notice.
Maybe adding such flag would help in your situation?
Thanks for clarifying your issue!
The update from 8.3.5 to 19.2.1 has several breaking issues. #901 was added in v9 and might cause your issue.
Looking at it now it would have been good to add a flag to enable/disable on multiple scopes. Might have even been a breaking change I guess but we didn't notice.
Maybe adding such flag would help in your situation?
yeah, a switch flag will solve my situation.
Would you be able to create a PR?
Would you be able to create a PR?
I'd like to try
@wlc015f I still don't grasp the issue here because you missed the "Steps to reproduce" part, can you at least attach the commitlint configuration you were using?
@wlc015f I still don't grasp the issue here because you missed the "Steps to reproduce" part, can you at least attach the commitlint configuration you were using?
add the details above
to Implement the feature, I have looked over the relevant code, and prefer to place the code related to parse message scopes with config under the @commitlint/parse module or into the conventional-commits-parser package, function scopeEnum
should just validate the rules with input config with parsed data. i need some advice/guidance @escapedcat @knocte
under the @commitlint/parse module or into the conventional-commits-parser package
Yeah, I guess you should aim at creating a PR here: https://github.com/conventional-changelog/conventional-changelog/tree/master/packages/conventional-commits-parser
to Implement the feature,
BTW, if I understood this ticket correctly, this is a bug, not a feature.
Yes, I guess it was a breaking change because multiple scopes were added "enabled by default", right? But it's done already... so I guess this "feature" is the best option?
BTW, if I understood this ticket correctly, this is a bug, not a feature.
Yes, I guess it was a breaking change because multiple scopes were added "enabled by default", right? But it's done already... so I guess this "feature" is the best option?
I think it should be worked on as a feature.
Would you be able to create a PR?
Would you be able to create a PR?
I'd like to try this weekend
Expected Behavior
our projects previous use scope like:
feat(A/B): commit msg
, B is a sub scope of A.when we update @commitlint/cli from 8.3.5 to 19.2.1 , it doesn't work well as before, because for version 19.2.1 "/" is scopes delimiter to divide input scope string into several scopes.
Current Behavior
scopeEnum
would divide input scope "A/B" to scope "A" and "B" to check if input scope in commitlint config rulesscope-enum
, we previous config scope "A/B" can not pass isScopeInEnum check.Steps to reproduce
commit-msg
npx --no -- commitlint --edit $1
test(workload/record): test commit
, then get error message below:β found 1 problems, 0 warnings β Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
husky - commit-msg script failed (code 1)