Open escapedcat opened 6 months ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
From what I've observed on https://github.com/insurgent-lab/commitlint-config/pull/99, upgrading conventional-changelog-conventionalcommits
to v8 in config-conventional
breaks the !
in commit titles:
validMessages: [
'fix: some message',
'refactor!: some message', // <- fails
'fix(scope): some message',
'fix(scope): some Message',
'fix(scope): some message\n\nBREAKING CHANGE: it will be significant!',
'fix(scope): some message\n\nbody',
'fix(scope)!: some message\n\nbody', // <- fails
],
CI test run: https://github.com/insurgent-lab/commitlint-config/actions/runs/9463301740/job/26068172529
Example failure from @commitlint/cli
:
⧗ input: refactor!: migrate to ESM
BREAKING CHANGE: the package is now pure ESM
✖ subject may not be empty [subject-empty]
✖ type may not be empty [type-empty]
✖ found 2 problems, 0 warnings
I'll stay on 7.0.2
for now, no big deal, I just wanted to add some potentially useful input here, especially since the failure in CI here isn't very helpful
Update packages:
@JounQin I gave it a try and failed. If you find some time maybe you can have a look?