conventional-changelog / commitlint

📓 Lint commit messages
https://commitlint.js.org
MIT License
16.94k stars 912 forks source link

fix: `body-max-line-length` is not respecting `footer-max-line-length` and failing for long footers #4088

Open rsampaths16 opened 5 months ago

rsampaths16 commented 5 months ago

Steps to Reproduce

1. First step
set rules 

{
  "body-max-line-length": [2, "always", 100],
  "footer-max-line-length": [2, "always", 150],
}

2. Second step
In commit have a footer greater than 100 characters and less than 150 characters

Current Behavior

The commitlint fails with body-max-line-length

Expected Behavior

It shouldn't fail with body-max-line-length as footer-max-line-length is respected

Affected packages

Possible Solution

No response

Context

Am facing this issue when using the commitlint-pre-commit-hook plugin for pre-commit.

Have current suppressed the checks with the following config

module.exports = {
    extends: ['@commitlint/config-conventional'],
    rules: {
        'body-max-line-length': [0, 'always', 0],
        'footer-max-line-length': [0, 'always', 0],
    }
};

commitlint --version

@commitlint/cli@19.3.0

git --version

v2.39.3

node --version

v12.22.12

SalahAdDin commented 3 months ago

I'm having the same issue right now, you can check here.