conventional-changelog / commitlint

📓 Lint commit messages
https://commitlint.js.org
MIT License
16.93k stars 912 forks source link

docs: remove GitLab clone depth limitation #4105

Closed abitrolly closed 4 months ago

abitrolly commented 4 months ago

See https://github.com/conventional-changelog/commitlint/issues/4103

Description

I removed stages key, because copy/pasting the block may break stages that people have defined already.

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

Checklist:

codesandbox-ci[bot] commented 4 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

escapedcat commented 4 months ago

Thanks!

I removed stages key, because copy/pasting the block may break stages that people have defined already.

You think it's worth adding i.e. a comment for these or just leave it out for now?

abitrolly commented 4 months ago

@escapedcat better leave it out for now, because there are more ways to organize when to run then job . For example, use special needs: [] syntax to run it as soon as possible regardless of stage.

https://docs.gitlab.com/ee/ci/pipelines/pipeline_architectures.html#pipelines-with-the-needs-keyword

Failing lint stage also aborts build stage, which may be not what people expect. Probably they want to see if tests pass and fix both tests and lint warnings for the next push.