feat(container): switch to Alpine container

conventional-changelog / commitlint

📓 Lint commit messages

https://commitlint.js.org

MIT License

16.93k stars 912 forks source link

feat(container): switch to Alpine container #4185

Closed skycaptain closed 2 weeks ago

skycaptain commented 1 month ago

Description

This reduces the container image size from about 950MB to 200MB.

Closes #4183.

Motivation and Context

See #4183

How Has This Been Tested?

$ docker buildx build -f Dockerfile.ci .

Types of changes

Although I've labeled this as a non-breaking change, it could potentially disrupt containers derived from this image. Please consider reclassifying it as a breaking change if necessary.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

escapedcat commented 1 month ago

/cc @kaiehrhardt @knocte would you mind having a look at this?

knocte commented 1 month ago

I have no idea about how this Dockerfile.ci is used

kaiehrhardt commented 1 month ago

@escapedcat lgtm

skycaptain commented 1 month ago

Is there a list of system dependencies for commitlint? I just realized yesterday that I forgot to add git, and I'm wondering whether there are more dependencies. Previously, many "basic" tools were available from the large base image, but they would now be missing if not explicitly installed. Are there other things I should test?

escapedcat commented 1 month ago

Is there a list of system dependencies for commitlint?

Haven't seen one. I'm also not exactly sure. Maybe we try this, give it a try and adjust if needed?

skycaptain commented 2 weeks ago

Jumping back on this PR. Is there anything still missing here, or shall we merge as @escapedcat suggested?

escapedcat commented 2 weeks ago

@skycaptain hey, yes, sorry! Let me merge it these days and we'll see what happens ;)

escapedcat commented 2 weeks ago

Done 🤞

escapedcat commented 1 week ago

Looks like this went well?