Cannot find module "@commitlint/config-conventional" when running commintlint globally

dexpota commented 5 years ago

Expected Behavior

I installed commitlint and commitlint/config-conventional globally, thus running echo 'hello world' | commitlint under any directory should works.

Current Behavior

The command raises an exception.

/usr/local/lib/node_modules/@commitlint/cli/lib/cli.js:67
                throw err;
                ^

Error: Cannot find module "@commitlint/config-conventional" from "/home/fabrizio"
    at resolveId (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:134:12)
    at resolveConfig (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:111:18)
    at /usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:63:18
    at Array.reduce (<anonymous>)
    at loadExtends (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:61:32)
    at resolveExtends (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:44:17)
    at Object.$If_1 (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/core/lib/load.js:90:46)
    at Object.<anonymous> (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/core/lib/load.js:159:18)
    at <anonymous>

Affected packages

[x] cli
[x] config-conventional

Steps to Reproduce (for bugs)

npm install -g @commitlint/cli @commitlint/config-conventional
echo "module.exports = {extends: ['@commitlint/config-conventional']};" > ~/.commitlintrc.js
echo 'should fail' | commitlint

commitlint.config.js

```js module.exports = {extends: ['@commitlint/config-conventional']}; ```

Your Environment

Executable	Version
`commitlint --version`	7.5.2
`git --version`	2.17.1
`node --version`	8.10.0

escapedcat commented 5 years ago

I think commitlint is usually being used on a per project basis. So each project has it's own config. If you want to use it globally like you tried you could use the --config option and try this:

echo 'should fail' | commitlint --config ~/.commitlintrc.js

dexpota commented 5 years ago

I tried your solution and is not working, the same exception as before.

From what I understand from issue #123 it should be possible to use commitlint from any directory starting from version 5.0.1.

knksmith57 commented 5 years ago

we're also running into this issue.

our goal is 0 configuration enforcement of conventional commits in CI --I expected the following to work:

❯ cd $(mktemp -d) && ls -a
.  ..

❯ export CI_COMMIT_MESSAGE='foo: bar'

❯ npx -p @commitlint/config-conventional -p @commitlint/cli -c 'echo $CI_COMMIT_MESSAGE | commitlint -x @commitlint/config-conventional'
npx: installed 137 in 8.51s
/Users/foo/.npm/_npx/6761/lib/node_modules/@commitlint/cli/lib/cli.js:113
    throw err;
    ^

Error: Cannot find module "@commitlint/config-conventional" from "/private/var/folders/xr/dxys9d310_s1j3klz_1xwz9jq1qqv5/T/tmp.BsKwQjE1QE"
    at resolveId (/Users/foo/.npm/_npx/6761/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:112:14)
    at resolveConfig (/Users/foo/.npm/_npx/6761/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:92:20)
    at reduce (/Users/foo/.npm/_npx/6761/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:49:20)
    at Array.reduce (<anonymous>)
    at loadExtends (/Users/foo/.npm/_npx/6761/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:47:32)
    at resolveExtends (/Users/foo/.npm/_npx/6761/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:30:19)
    at Object.$If_1 (/Users/foo/.npm/_npx/6761/lib/node_modules/@commitlint/cli/node_modules/@commitlint/load/lib/index.js:69:45)
    at Object.<anonymous> (/Users/foo/.npm/_npx/6761/lib/node_modules/@commitlint/cli/node_modules/@commitlint/load/lib/index.js:142:17)

escapedcat commented 5 years ago

@dexpota I just tried this on a clean Ubuntu VM:

npm install -g @commitlint/config-conventional @commitlint/cli
echo "module.exports = {extends: ['@commitlint/config-conventional']}" > ~/.commitlintrc.js
echo "hello world" | commitlint

Output is:

⧗   input: hello world
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]
✖   found 2 problems, 0 warnings 
    (Need help? -> https://github.com/conventional-changelog/commitlint#what-is-commitlint )

cat ~/.commitlintrc.js
module.exports = {extends: ['@commitlint/config-conventional']}

I'm sorry, but I can't reproduce your issue.

This issue is related to https://github.com/conventional-changelog/commitlint/issues/126#issuecomment-345508707

dexpota commented 5 years ago

Which version of Ubuntu are you using? I tried with Ubuntu 18.04 on a VM created with vagrant and I am having the same problem.

/usr/local/lib/node_modules/@commitlint/cli/lib/cli.js:113
        throw err;
        ^

Error: Cannot find module "@commitlint/config-conventional" from "/home/vagrant"
    at resolveId (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:112:14)
    at resolveConfig (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:92:20)
    at reduce (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:49:20)
    at Array.reduce (<anonymous>)
    at loadExtends (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:47:32)
    at resolveExtends (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:30:19)
    at Object.$If_1 (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/load/lib/index.js:69:45)
    at Object.<anonymous> (/usr/local/lib/node_modules/@commitlint/cli/node_modules/@commitlint/load/lib/index.js:142:17)
    at <anonymous>

Here more information about the tool versions:

vagrant@ubuntu-bionic:~$ npm --version                                                      
3.5.2
vagrant@ubuntu-bionic:~$ node --version
v8.10.0
vagrant@ubuntu-bionic:~$ git --version
git version 2.17.1
vagrant@ubuntu-bionic:~$ commitlint --version
7.5.2

and these are the steps to recreate the VM using vagrant:

vagrant init ubuntu/bionic64
vagrant up
vagran ssh

escapedcat commented 5 years ago

Alright, it's the node version! I used Ubuntu 18.04 with latest npm/node. Sorry for saying clean. I should have mentioned that. Is it possible for you to update the node version? I'm not sure how much effort we would put in to make this case work (again) in v8.

dexpota commented 5 years ago

I tried with node version 10.15.3 and npm version 6.4.1 and now it's working.

knksmith57 commented 5 years ago

to provide some color --it looks like our issue is slightly different from the one reported here.

I can deterministically reproduce the module resolution failure on both node 8.x and 10.x when using npx to fetch and run commitlint; however, I cannot reproduce on either 8.x or 10.x if the modules are first installed globally.

works with `npm i -g`

npm i -g @commitlint/config-conventional @commitlint/cli
echo 'hello world' \
  | commitlint -x @commitlint/config-conventional

``` ❯ docker run --rm -i --entrypoint sh node:8.15.1 <<'EOT' npm i -g @commitlint/config-conventional @commitlint/cli echo 'hello world' \ | commitlint -x @commitlint/config-conventional EOT /usr/local/bin/commitlint -> /usr/local/lib/node_modules/@commitlint/cli/lib/cli.js + @commitlint/config-conventional@7.5.0 + @commitlint/cli@7.5.2 added 137 packages from 64 contributors in 9.439s ⧗ input: hello world ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings (Need help? -> https://github.com/conventional-changelog/commitlint#what-is-commitlint ) ``` ``` ❯ docker run --rm -i --entrypoint sh node:10.15.3 <<'EOT' npm i -g @commitlint/config-conventional @commitlint/cli echo 'hello world' \ | commitlint -x @commitlint/config-conventional EOT /usr/local/bin/commitlint -> /usr/local/lib/node_modules/@commitlint/cli/lib/cli.js + @commitlint/config-conventional@7.5.0 + @commitlint/cli@7.5.2 added 137 packages from 64 contributors in 10.263s ⧗ input: hello world ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings (Need help? -> https://github.com/conventional-changelog/commitlint#what-is-commitlint ) ```

fails with `npx -p`

echo 'hello world' \
  | npx \
    -p @commitlint/config-conventional \
    -p @commitlint/cli \
  commitlint -x @commitlint/config-conventional

``` ❯ docker run --rm -i --entrypoint sh node:8.15.1 <<'EOT' echo 'hello world' \ | npx \ -p @commitlint/config-conventional \ -p @commitlint/cli \ commitlint -x @commitlint/config-conventional EOT npx: installed 137 in 9.894s /root/.npm/_npx/7/lib/node_modules/@commitlint/cli/lib/cli.js:113 throw err; ^ Error: Cannot find module "@commitlint/config-conventional" from "/" at resolveId (/root/.npm/_npx/7/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:112:14) at resolveConfig (/root/.npm/_npx/7/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:92:20) at reduce (/root/.npm/_npx/7/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:49:20) at Array.reduce () at loadExtends (/root/.npm/_npx/7/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:47:32) at resolveExtends (/root/.npm/_npx/7/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:30:19) at Object.$If_1 (/root/.npm/_npx/7/lib/node_modules/@commitlint/cli/node_modules/@commitlint/load/lib/index.js:69:45) at Object. (/root/.npm/_npx/7/lib/node_modules/@commitlint/cli/node_modules/@commitlint/load/lib/index.js:142:17) at ``` ``` ❯ docker run --rm -i --entrypoint sh node:10.15.3 <<'EOT' echo 'hello world' \ | npx \ -p @commitlint/config-conventional \ -p @commitlint/cli \ commitlint -x @commitlint/config-conventional EOT npx: installed 137 in 8.683s /root/.npm/_npx/9/lib/node_modules/@commitlint/cli/lib/cli.js:113 throw err; ^ Error: Cannot find module "@commitlint/config-conventional" from "/" at resolveId (/root/.npm/_npx/9/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:112:14) at resolveConfig (/root/.npm/_npx/9/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:92:20) at reduce (/root/.npm/_npx/9/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:49:20) at Array.reduce () at loadExtends (/root/.npm/_npx/9/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:47:32) at resolveExtends (/root/.npm/_npx/9/lib/node_modules/@commitlint/cli/node_modules/@commitlint/resolve-extends/lib/index.js:30:19) at Object.$If_1 (/root/.npm/_npx/9/lib/node_modules/@commitlint/cli/node_modules/@commitlint/load/lib/index.js:69:45) at Object. (/root/.npm/_npx/9/lib/node_modules/@commitlint/cli/node_modules/@commitlint/load/lib/index.js:142:17) ```

At this point I'm thinking this is either an issue with @commitlint/resolve-extends or a bug in npx.