search

conventional-changelog / conventional-changelog

Generate changelogs and release notes from a project's commit messages and metadata.
ISC License
7.68k stars 716 forks source link

missing argument at conventional-changelog #581

Open eunjae-lee opened 4 years ago

eunjae-lee commented 4 years ago

Hello, I'm not sure if this is a bug or not.

If you look at https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-changelog/index.js#L23

conventionalChangelogCore(options, context, gitRawCommitsOpts, parserOpts, writerOpts)

it's calling conventionalChangelogCore with 5 arguments.

However, if you look at https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-changelog-core/index.js#L13

function conventionalChangelog (options, context, gitRawCommitsOpts, parserOpts, writerOpts, gitRawExecOpts) {

it's expecting 6 arguments.

I am using conventional-changelog package directly and I need to pass gitRawExecOpts because the working directory is different from the destination directory where git command should be run.

If it's okay, I will open a PR to add the 6th argument.

vivaxy commented 4 years ago

Related to https://github.com/conventional-changelog/conventional-changelog/pull/480