conventional-changelog / standard-version

:trophy: Automate versioning and CHANGELOG generation, with semver.org and conventionalcommits.org
ISC License
7.69k stars 794 forks source link

Custom updater for bumpFiles/packageFiles not loaded when provided as JS-object #933

Open StefanHuettenmoserECMT opened 1 year ago

StefanHuettenmoserECMT commented 1 year ago

Describe the bug The custom updater is empty when passing it as an JS-object (with readVersion/writeVersion functions). It works when adding it via filepath.

Current behavior Current output is as bellow. Note the updater is empty. A tracker is supplied with filename (as string) and updater (as object with readVersion/writeVersion-methods).

Unable to obtain updater for: {"filename":".env","updater":{}}

Expected behavior Updater should be loaded and not be empty

Environment

Possible Solution When checking if the updater is valid for the first time, the argument should be updater.updater (as in line 80)

Thank you very much for your dedication to this valuable project!

TimothyJones commented 1 year ago

This project is deprecated - but I forked it as commit-and-tag-version here.

I believe this issue was fixed in 10.0.1 of commit-and-tag-version - give it a try and see if it works for you.