search

conventional-commits / conventionalcommits.org

The conventional commits specification
https://conventionalcommits.org
MIT License
7.02k stars 542 forks source link

zh/ja show unncessary spaces are generated from Markdown newlines #193

Open Artoria2e5 opened 5 years ago

Artoria2e5 commented 5 years ago

Markdown translates newlines to spaces, which works pretty well for languages that use spaces but not for others like Chinese and Japanese. These languages don't usually use spaces between words, and they definitely don't need spaces after their full-width punctuation marks that already give the space space. But, well, the nicely-newlined summary part are showing spaces everywhere as a result of this neatness. Copy the zh summary into a code editor and you will see it.

We should either ask the Markdown engine to do this (which Hugo cannot do; its CJK support is only for word count) or sacrifise this neatness of source away in these languages. Maybe we should even leave a note for translators who later do similar languages.

damianopetrungaro commented 5 years ago

Hey @Artoria2e5 ! Thanks for the feedback! Do you want to prepare a PR for that? It would be awesome!

Artoria2e5 commented 5 years ago

It is going to mess up a lot of diffs, so I figured that you can maybe @ me before a release to do that…