Open goveo opened 1 year ago
I think scoping the commit type would be the solution to that with the current convention
Example: feat(loading-button): made button disabled while loading
It depends what you are improving @goveo :D
If the improve is a performance issue, fix
should be the type since also reflects the minor release in SemVer.
If the improve you're doing is building a functionality (example changing the color of a button while loading), then it is a feat
:)
Sometimes it can be argued that the change in question is a fix: if users can open the same file multiple times by clicking the load button repeatedly (because it is not disabled), which is a behavior that does not provide any value to the users and should not be allowed by the application, then disabling the button while loading can be considered more of fix
than a feat
.
I've been using conventional-commits mostly with reusable components, and found that the difference between fix
and feat
is clear-cut, and aligns well with SemVer. With applications/products, however, it's a different story:
feat
aligns with MINOR)
Sometimes I have changes that are not a new feature itself, but a small addition to current functionality.
feat:
andfix:
seems like not the best types for this case.I think something like
imp:
(an abbreviation ofimprovement:
) should fit great in cases like this. CHANGELOGs can generate the improvements section based on these commits.What do you think?