search

conventional-commits / conventionalcommits.org

The conventional commits specification
https://conventionalcommits.org
MIT License
7.19k stars 557 forks source link

Please change background color of website to be less hard on the eyes #516

Open c32hedge opened 1 year ago

c32hedge commented 1 year ago

The current hot pink/salmon color is not only a poor contrast with the white text, it's also very hard on the eyes especially given that it takes up most or all of the screen when you first visit the site (https://www.conventionalcommits.org/en/v1.0.0/).

Might I suggest using a more neutral color? And maybe having the colored portion take up less vertical space? After all, a site advocating conventions for making commit messages readable should itself be as readable as possible.

jenstroeger commented 1 year ago

Considering the Web Accessibility Initiative (WAI), perhaps take a look at color contrast checkers like this one.

Potherca commented 1 year ago

To give an idea (and save interested parties the effort), using Chrome devtools contrast check

image

Beside specific classes button.dropdown__label, a.no-style-a, h1.welcome__title, p.welcome__description, a.welcome__action, there are issues with the a, and code tags.

damianopetrungaro commented 1 year ago

Hey @Potherca @jenstroeger @c32hedge, sorry, I missed this!

Does any of you want to volunteer and open a PR to improve this? I am open to changing colors!

Before any of you write some code, please, share a palette of colors you are suggesting.