search

conversant / disruptor

Disruptor BlockingQueue
Apache License 2.0
311 stars 47 forks source link

Declare an Automatic Module Name #15

Closed rgoers closed 4 years ago

rgoers commented 4 years ago

Log4j 2 uses this library as an optional dependency. One of the goals of Log4j 2 3.x is to support the Java Platform Module System. To do that every dependency it uses must declare its module name. The fully compliant way to do that would be to create a module-info.java file, but at the very least the Automatic-Module-Name header needs to be added to META-INF/MANIFEST.MF to declare the name of the module. Otherwise Java will use the jar name minus the version, which is almost always going to be a problem.

jac18281828 commented 4 years ago

@evanwht1 you were correct. We need to be using exports. Will fix!

jac18281828 commented 4 years ago

fixed in https://github.com/conversant/disruptor/releases/tag/1.2.17

@rgoers you should be good to go as soon as it propagates.