search

conversant / disruptor

Disruptor BlockingQueue
Apache License 2.0
311 stars 47 forks source link

15: support java 11, add module-info #16

Closed jac18281828 closed 4 years ago

jac18281828 commented 4 years ago

closes #15

This should take care of it. Let me know if you agree.

evanwht commented 4 years ago

Is there any merit to keeping the jdk8 profile? I'm fine with removing the jdk10 profile in favor of jdk11. The read me could use an update with these changes.

jac18281828 commented 4 years ago

Is there any merit to keeping the jdk8 profile? I'm fine with removing the jdk10 profile in favor of jdk11. The read me could use an update with these changes.

Personally I don't think so and don't use it. Do you guys still need it? I think at this point thats pretty old.

jac18281828 commented 4 years ago

Is there any merit to keeping the jdk8 profile? I'm fine with removing the jdk10 profile in favor of jdk11. The read me could use an update with these changes.

Personally I don't think so and don't use it. Do you guys still need it? I think at this point thats pretty old.

BTW - all the existing Java 8 releases are still there and this is not a code change so Java 8 Luddite community is not deprived. This change would just not provide support for future changes on Java 8 😈

evanwht commented 4 years ago

BTW - all the existing Java 8 releases are still there and this is not a code change so Java 8 Luddite community is not deprived. This change would just not provide support for future changes on Java 8 😈

Sounds good. We will want to update the read me when this gets released.

jac18281828 commented 4 years ago

Thanks @evanwht1 🦌