search

conversant / disruptor

Disruptor BlockingQueue
Apache License 2.0
311 stars 47 forks source link

slf4j dependency is only required by a Test : change scope to test in pom.xml #21

Closed fgdrf closed 4 years ago

fgdrf commented 4 years ago

https://github.com/conversant/disruptor/blob/7f3c0331ce010cbbc29df2791c57024896bede28/pom.xml#L235

I had a look from GeoTools project perspective an was wondering why slf4j is in dependency but not referenced in any runtime class.

This leads to dependency conflicts in downstream projects and could easily fixed be adding scope test

jac18281828 commented 4 years ago

Thanks for noticing this!