search

conversationai / perspectiveapi-authorship-demo

Example code to illustrate how to build an authorship experience using the perspective API
Apache License 2.0
66 stars 22 forks source link

HttpClient update and corresponding test fixes. #81

Closed iislucas closed 5 years ago

iislucas commented 6 years ago

Updates from the deprecated Http to HttpClient and fixes all the tests. Also removes the "external" mode from the checker component since it was an old design and isn't being used (allowing a few tests to be removed!)

iislucas commented 5 years ago

Hi Rachel, I saw you did a bunch more work here... what's the latest status on this? I have some things that depend on this landing that I'd like to unblock. cheers!

iislucas commented 5 years ago

Actually, if you like I can take it from here, and then you review after I do the next step.

rachelrosengoogle commented 5 years ago

We probably don't want to put too much into a single PR--it might be better to do new work in a new branch.

I just updated and responded to some of the comments; let's sync up tomorrow on the TODOs to clarify them.

iislucas commented 5 years ago

Nice work! I did a small tweak to clarify the finalize and merged.

rachelrosengoogle commented 5 years ago

I've confirmed that this PR is what caused #87. I haven't yet pinned down which piece of this very large change caused that or how to fix it, but I will update once I know more.