Profile button not doing anything

licaon-kter commented 5 years ago

...while it should pop up to see/set your info and OMEMO keys.

HEAD (https://github.com/conversejs/converse.js/commit/720096726d7a8cd09d17329316827b1d3d4f7f63)

git bisect says:

ef5ecb2f3aa4575056e9541a3892416212f80d34 is the first bad commit
commit ef5ecb2f3aa4575056e9541a3892416212f80d34
Author: JC Brand <jc@opkode.com>
Date:   Mon Aug 5 11:07:38 2019 +0200

    Decouple converse-controlbox and converse-profile

 src/converse-chatview.js   |  2 +-
 src/converse-controlbox.js | 18 +++++++-----------
 src/converse-profile.js    |  8 ++++++++
 src/converse.js            |  1 +
 4 files changed, 17 insertions(+), 12 deletions(-)

--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/78422009-profile-button-not-doing-anything?utm_campaign=plugin&utm_content=tracker%2F194169&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F194169&utm_medium=issues&utm_source=github).

jcbrand commented 5 years ago

Works for me, but I don't have libsignal loaded which might be why. Do you see any error messages in the browser console that you can paste here?

licaon-kter commented 5 years ago

On connect in Firefox Stable:

Plugin "converse-omemo" tried to override "ProfileModal" but it's not found.

On avatar click in Firefox Stable:

TypeError: e.view.other_devices is undefined profile_modal.html:1
    exports profile_modal.html:1
    toHTML converse-profile.js:62
    render Backbone
    initialize converse-modal.js:26
    initialize converse-profile.js:51
    Backbone 5
    showProfileModal converse-profile.js:267
    showProfileModal self-hosted:1003
    u Backbone

On avatar click in Vivaldi Snapshot:

profile_modal.html:1 Uncaught TypeError: Cannot read property 'length' of undefined
    at e.exports (profile_modal.html:1)
    at o.toHTML (converse-profile.js:62)
    at o.render (backbone.vdomview.js:108)
    at o.initialize (converse-modal.js:26)
    at o.initialize (converse-profile.js:51)
    at o.t.View (backbone.js:1300)
    at o.constructor (backbone.nativeview.js:66)
    at o [as constructor] (backbone.js:2060)
    at o [as constructor] (backbone.js:2060)
    at new o (backbone.js:2060)

jcbrand commented 5 years ago

@licaon-kter Thank you, these bug reports are super helpful.

Should be fixed now, could you please double check?

licaon-kter commented 5 years ago

Yup, fixed

licaon-kter commented 3 years ago

I see this again on HEAD (58c5e9676a27a01fa2fb47ab496d9f9bb8e29269), Firefox Desktop, private window, uncheck trusted

Click on avatar yields:

Uncaught TypeError: xc.devicelists is undefined
    initialize omemo.js:630
    wrappedOverride pluggable.js:71
    Lodash 2
    wh view.js:45
    r helpers.js:32
    r helpers.js:32
    create modal.js:58
    show modal.js:38
    showProfileModal profile.js:64
    i view.js:188
    delegate view.js:193
    delegateEvents view.js:150
    setElement view.js:105
    _ensureElement view.js:253
    wh view.js:44
    r helpers.js:32
    r helpers.js:32
    initialize profile.js:106
    Gi events.js:281
    $i events.js:264
    Bi events.js:50
    trigger events.js:254
    trigger core.js:445
    initialize pane.js:15
    wh view.js:45
    r helpers.js:32
    renderControlBoxPane view.js:113
    renderControlBoxPane index.js:94
    wrappedOverride pluggable.js:71
    Lodash 2
    renderControlBoxPane index.js:36
    wrappedOverride pluggable.js:71
    Lodash 2
    render view.js:71
    onConnected view.js:78
    Gi events.js:283
    $i events.js:264
    Bi events.js:50
    trigger events.js:254
    set model.js:208
    save model.js:318
    fy index.js:59
    Gi events.js:280
    $i events.js:264
omemo.js:630:16
    initialize omemo.js:630
    wrappedOverride pluggable.js:71
    Lodash 2
    wh view.js:45
    r helpers.js:32
    r helpers.js:32
    create modal.js:58
    show modal.js:38
    showProfileModal profile.js:64
    showProfileModal self-hosted:1161
    i view.js:188
    (Async: EventListener.handleEvent)
    delegate view.js:193
    delegateEvents view.js:150
    setElement view.js:105
    _ensureElement view.js:253
    wh view.js:44
    r helpers.js:32
    r helpers.js:32
    initialize profile.js:106
    InterpretGeneratorResume self-hosted:1468
    AsyncFunctionNext self-hosted:674
    (Async: async)
    Gi events.js:281
    $i events.js:264
    Bi events.js:50
    trigger events.js:254
    trigger core.js:445
    initialize pane.js:15
    wh view.js:45
    r helpers.js:32
    renderControlBoxPane view.js:113
    renderControlBoxPane self-hosted:1161
    renderControlBoxPane index.js:94
    wrappedOverride pluggable.js:71
    Lodash 2
    t self-hosted:1161
    renderControlBoxPane index.js:36
    wrappedOverride pluggable.js:71
    Lodash 2
    render view.js:71
    onConnected view.js:78
    Gi events.js:283
    $i events.js:264
    Bi events.js:50
    trigger events.js:254
    set model.js:208
    save model.js:318
    fy index.js:59
    Gi events.js:280
    $i events.js:264

conversejs / converse.js

Profile button not doing anything #1670