conversejs / converse.js

Web-based XMPP/Jabber chat client written in JavaScript
http://conversejs.org
Mozilla Public License 2.0
3.08k stars 772 forks source link

Allow mobile view-mode on tablets with higher horizontal resolution #2082

Open poVoq opened 4 years ago

poVoq commented 4 years ago

Is your feature request related to a problem? Please describe. Yes, see: https://github.com/conversejs/converse.js/issues/1057

Describe the solution you'd like As described here: https://github.com/poVoq/conversejs-ubports/issues/7 the mobile view-mode overlay disappears on larger horizontal screen resolutions (in the above case only in landscape mode of the tablet). It would be great if that could be prevented somehow.

Describe alternatives you've considered I am thinking about adding a manual toggle to switch between fullscreen and mobile view-mode, but that requires logging out of ConverseJS.

Additional context Specifically this issue happens on Ubuntu Touch tablets, but it is in fact a general problem with the mobile view mode as soon as the browser window as a too high horizontal screen resolution.

--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/91677386-allow-mobile-view-mode-on-tablets-with-higher-horizontal-resolution?utm_campaign=plugin&utm_content=tracker%2F194169&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F194169&utm_medium=issues&utm_source=github).
jcbrand commented 2 months ago

Closing. See: https://github.com/conversejs/converse.js/commit/3a754a00e49a69a5dbcc42a59f7ab77bad4889dd