conversejs / converse.js

Web-based XMPP/Jabber chat client written in JavaScript
http://conversejs.org
Mozilla Public License 2.0
3.06k stars 763 forks source link

XEP-0444: Message reactions #2398

Open alexanderadam opened 3 years ago

alexanderadam commented 3 years ago

Is your feature request related to a problem? Please describe.

It would be nice to have message reactions.

Describe the solution you'd like

An implementation of XEP-0444 (:page_facing_up: PDF), I guess?

Describe alternatives you've considered

I never understand what I should write here in case of features requests. The answer here would be "not using message reactions". :wink:

Additional context Add any other context or screenshots about the feature request here.

PS: I just saw that it might already be available in converse. Do I have to activate something or did I miss something? I mean, it's not listed yet in the README, right?

--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/96399176-xep-0444-message-reactions?utm_campaign=plugin&utm_content=tracker%2F194169&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F194169&utm_medium=issues&utm_source=github).
jcbrand commented 3 years ago

It's not yet clear to me how well reactions work with MAM archiving.

AFAIK if you have 1 message followed 99 reactions, then when you query MAM for the last 100 message, you'll end up showing only that 1 message (and its reactions).

That's why XEP-0427 MAM Fastening Collation was created, but XEP-0444 doesn't use Fastenings. https://xmpp.org/extensions/xep-0427.html

IMO this lack of MAM support is a fundamental flaw of XEP-0444.

alexanderadam commented 3 years ago

Ah okay, I see. I wasn't aware of that (I'm just a user without technical insights).

Should I close this issue then until there's a 'fixed' XEP or should I keep it open for tracking and further proposes?

jcbrand commented 3 years ago

We can keep this one open until there is more clarity on what/how to implement this.

CyberFox001 commented 3 months ago

I don't know if that can help to clarify on what/how to implement this XEP, but the clients Gajim and Dino have implemented it.