search

conversejs / converse.js

Web-based XMPP/Jabber chat client written in JavaScript
http://conversejs.org
Mozilla Public License 2.0
3.04k stars 764 forks source link

Hidden encrypted media reappears #2606

Open licaon-kter opened 2 years ago

licaon-kter commented 2 years ago

To Reproduce Steps to reproduce the behavior:

  1. Go to an image
  2. Click on menu -> Hide media
  3. See image disappear and reappear

Expected behavior Media stays hidden

Environment (please complete the following information):

Additional context The menu text changes to "Show media" as expected, clicking it it changes to "Hide media" as expected

--- Want to back this issue? **[Post a bounty on it!](https://app.bountysource.com/issues/100642932-hidden-encrypted-media-reappears?utm_campaign=plugin&utm_content=tracker%2F194169&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://app.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F194169&utm_medium=issues&utm_source=github).
jcbrand commented 2 years ago

I''m not able to reproduce this bug. Tried it in both Firefox and Brave.

Do you see any errors in the console?

licaon-kter commented 2 years ago

Still an issue on 8f2f3e6498311c6d58b8131a38967088637a47df

No errors in console, as debug

Firefox Latest or Vivaldi Snapshot

licaon-kter commented 2 years ago

Updated to f40a8f69ae601f3c9fb7fc71c4b056e82a9366a5 and now only OMEMO media has this issue, unencrypted images are collapsed and replaced with URLs as expected

licaon-kter commented 2 years ago

Still and issue with 9e48fdc91ca3adbe20047928778def70d36f4484

licaon-kter commented 2 years ago

With 1104b28758e07f9423cbdb2e6c1a5af4a10f5c22 OMEMO images don't even have an action button